GLTFDocument: don't serialize empty buffers#109722
Merged
Merged
Conversation
AThousandShips
added
bug
enhancement
topic:3d
cherrypick:4.5
aaronfranke
reviewed
Aug 22, 2025
Repiteo
removed
the
cherrypick:4.5
Member
|
Actually, PR #109449 is taking too long to be reviewed, and I'd like to move forward with glTF 2.1. I'd like to get this merged in, then work on glTF 2.1 on top of this, then I can rebase PR #109449 on top of that later. Can you rebase this? The code looks good to me, and I rebased it locally to test it, and it works as expected. |
nikitalita
force-pushed
the
fix-gltf-empty-buffers
branch
from
2075138 to
a41f7c5
Compare
Contributor
Author
|
rebased |
aaronfranke
approved these changes
Jun 22, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing to GLTF, we don't want to write buffers if they're empty (it's against spec). This changes the serializing process so that empty buffers are not added to the document or written to disk (unless there are non-empty buffers subsequent to it, which is specifically handled).